AltGr broken after Ctrl-Escape / Escape

[fladnag]

Environment

• server : debian 8, xpra 0.14.10
• client : win 7, xpra 0.14.24, from winswitch, but using only xpra_cmd.exe

Keyboard : fr - default

Logs: SERVER and USER have been replaced for security reasons

xpra start :100 -d keyboard
DISPLAY=:100 xterm &

xpra attach ssh:...:100 -d keyboard

Steps:

• focus xterm
• press AltGr}} + {{{3 : OK, shows "#"
• press Ctrl + Escape: opens windows start menu
• press Escape: closes start menu
• press AltGr}} + {{{3 : OK, shows "#"
• press Ctrl + Escape: opens windows start menu
• press Escape: closes start menu
• click on xterm window
• press AltGr}} + {{{3 : bug, prints "£" instead of "#"
• press Backspace : bug, prints "ÿ" instead

[fladnag]

Another issue with AltGr? (same environment)
AltGr? down event persist without up event. So, typing :
a produce æ
b produce ”
c produce ¢
d produce ð
e produce €
etc...

in xpra client log, just before that, I saw the following lines :

2015-08-08 12:56:49,299 unexpected message: 49768 / 0 / 0
2015-08-08 12:58:30,700 unexpected message: 992 / 394642 / -1073102706
2015-08-08 13:23:26,219 unexpected message: 49577 / 2 / 0

[Antoine Martin]

Sorry for the long delay in dealing with this bug and thank you for the detailed bug report.
This has uncovered a serious bug which has been there for many years and may have had all sorts of undesirable side effects.

The trivial server side fix is in r11247, and it will be included in the next stable update.

And since I was there, I improved the code a bit more:

• r11248 makes the code easier to read
• r11249 should workaround any bugs by using the "big hammer": a full keyboard reset
• r11250 is a better way of choosing a modifier key to unpress (may also backport this one)
• r11254 only loops over modifiers lists if they are actually different, after' removing the ones we don't care about

Thought: maybe we should keep track of which modifier keycodes are used?
(at the moment, when we need to add a modifier, we pick the first keycode that matches)

@fladnag: please close when you have time to confirm that this is fixed (will make new beta builds soon)

[Antoine Martin]

Closing as fixed. Feel free to re-open if you still have problems.

[fladnag]

fix ok in 0.16.0-1 ;o)

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/923