xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 6 years ago

Closed 6 years ago

Last modified 6 months ago

#925 closed defect (invalid)

opencl csc is broken

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: critical Milestone: 0.16
Component: encodings Version: 0.15.x
Keywords: Cc:

Description

No idea when it broke, but it isn't doing anything anymore, just giving a blank memory area.
I was hoping to see if we can switch to using read-only memory for our pixel data, but since I can't test at all... this will have to wait.

I have updated to ​pyopencl version 2015.1, maybe this has something to do with it.

I am tempted to just remove the whole thing, we can resurrect it if we need to.

Attachments (5)

opencl-constify.patch​ (1.8 KB) - added by Antoine Martin 6 years ago.
if the kernel was actually doing something, I could tell if this is worth applying or not
opencl-debug-and-tweaks.patch​ (5.0 KB) - added by Antoine Martin 6 years ago.
some tweaks to see if the queuing is part of the problem handle memoryviews, etc..
test_opencl.py​ (3.0 KB) - added by Antoine Martin 6 years ago.
example code that does work
opencl-imageinterface.patch​ (12.2 KB) - added by Antoine Martin 6 years ago.
use the image interface instead of buffers, more like the working example
opencl-reinit-notest.patch​ (4.7 KB) - added by Antoine Martin 6 years ago.
reinit before running to ensure we get a clean context, and avoid running selftest (different thread)

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Antoine Martin

Attachment: opencl-constify.patch​ added

if the kernel was actually doing something, I could tell if this is worth applying or not

Changed 6 years ago by Antoine Martin

Attachment: opencl-debug-and-tweaks.patch​ added

some tweaks to see if the queuing is part of the problem handle memoryviews, etc..

Changed 6 years ago by Antoine Martin

Attachment: test_opencl.py​ added

example code that does work

Changed 6 years ago by Antoine Martin

Attachment: opencl-imageinterface.patch​ added

use the image interface instead of buffers, more like the working example

Changed 6 years ago by Antoine Martin

Attachment: opencl-reinit-notest.patch​ added

reinit before running to ensure we get a clean context, and avoid running selftest (different thread)

comment:1 Changed 6 years ago by Antoine Martin

Status: new → assigned

Some minor fixes in r10024, but despite all the attempts in the patches above, no clue as to what is broken.

Note: if / when we do fix it, r10058 uses read-only buffers so we may have to require a sufficiently new version of opencl to avoid errors.

Last edited 6 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 6 years ago by Antoine Martin

Resolution: → invalid
Status: assigned → closed

Well, I have no idea what happened here, but it fixed itself after a reboot...

comment:3 Changed 6 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/925

Note: See TracTickets for help on using tickets.