xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 9 years ago

Closed 9 years ago

Last modified 8 months ago

#97 closed enhancement (fixed)

vpx encoding support

Reported by: Antoine Martin Owned by: ahuillet
Priority: minor Milestone: 0.2
Component: core Version: 0.1.0
Keywords: Cc:

Description

the vpx api is almost identical to x264 so this is easy to add, the patch almost works but I must be doing something wrong with the packing/index of the channels

Attachments (1)

xpra-vpx.patch (17.5 KB) - added by Antoine Martin 9 years ago.
vpx almost working

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Antoine Martin

Attachment: xpra-vpx.patch added

vpx almost working

comment:1 Changed 9 years ago by Antoine Martin

Owner: changed from Antoine Martin to ahuillet
Status: newassigned

please take a look, I am sure you can figure out what I did wrong quickly

note: when merging the x264 and vpx codepaths can be merged (in server.py and window_backing.py), only the implementation class is different (and the dimensions rounding - but this can also be moved to a codec class attribute).

comment:2 Changed 9 years ago by ahuillet

  • Your mask for window size is incorrect - should be FFFE to ensure even dimensions, FFFF just truncates it to < 65535.
  • Are you sure that libvpx can do the RGB -> YUV420 colorspace conversion by itself? You're allocating an input picture in YUV420 format but filling it in with RGB packed data (hence a single plane)
  • Same on the decompress side: the codec probably works with YUV420 (or any other form of YUV), but your output should be RGB

comment:3 Changed 9 years ago by Antoine Martin

Resolution: fixed
Status: assignedclosed
  • the mask is OK, vpx does not seem to mind odd dimensions, I left the mask code in to make it easier to merge the x264 and vpx code together
  • rgb-yuv: yes, obviously.. that did the trick

r677 fixes the colourspace and vpx is now supported (also refactored the x264 code to re-use as much code as possible)

comment:4 Changed 9 years ago by Antoine Martin

Milestone: 0.10.2

comment:5 Changed 8 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/97

Note: See TracTickets for help on using tickets.