Timeline
10/28/14:
- 22:54 Changeset in xpra [7994] by
- #473 auto connection improvements * host and port fields are …
- 16:55 Changeset in xpra [7993] by
- fix WM_CLASS detection: * use XGetClassHint which gives us more …
- 10:37 Changeset in xpra [7992] by
- force rebuild for ABI break
- 09:43 Ticket #706 (Input cjk text on forwarded window) closed by
- needinfo: Closing. FYI: the "reporting keyboard bugs" has lots of details on how …
10/27/14:
- 20:49 Ticket #722 (Using --password= and --password-file= causes SSH to fail to login) closed by
-
invalid: This is not a bug.
The
password-file
switch (which is the only … - 20:15 Ticket #722 (Using --password= and --password-file= causes SSH to fail to login) created by
- Tested with Win7 r7897 against a Fedora 20 r7897 server: Connecting …
- 20:13 Changeset in xpra [7991] by
- make it easier to test changes to the build file: add …
- 19:22 Ticket #712 (server is not responding) closed by
- duplicate: I believe this is a duplicate of #669, will follow up there. Closing.
- 19:17 Ticket #703 (Copying URL from web browser address bar on remote host fails) closed by
- worksforme: Not heard back, hopefully 40 is enough here.
- 19:16 Ticket #702 (Connection gets lost after eclipse auto-completion window is activated) closed by
- needinfo: Not heard back. Closing.
- 19:11 Ticket #666 (start-child drops command line arguments) closed by
- fixed: Backported in r7926.
- 17:49 Ticket #688 (build script for rpm packages) closed by
- fixed: I've done all of this, and even more: * sound packages for mp3 support …
- 17:46 Ticket #676 (Allow admin to restrict the user's ability to overwrite xpra config ...) closed by
- wontfix: Not heard back.
- 17:36 Ticket #661 (Hard to switch keyboard layout using hot keys; "Keyboard" menu has no ...) closed by
- fixed: Backport was in r7892. Closing.
- 09:19 Changeset in xpra [7990] by
- prevent None values from making it into xpra info, causing the …
10/26/14:
- 20:57 Changeset in xpra [7989] by
- oops: missing import
10/25/14:
- 21:22 Changeset in xpra [7988] by
- changes needed for building for centos 6+
- 19:48 Changeset in xpra [7987] by
- better error detection
- 18:24 Changeset in xpra [7986] by
- need a version bump to prevent yum from "upgrading" our patched …
- 16:31 Changeset in xpra [7985] by
- * expose linux kernel version with the nvidia module version * don't …
- 16:16 Changeset in xpra [7984] by
- lower maximum number of contexts, since latency starts suffering with …
- 14:15 Changeset in xpra [7983] by
- webp version bump for osx
- 13:51 Changeset in xpra [7982] by
- new upstream release
- 13:38 Changeset in xpra [7981] by
- new upstream release
- 10:43 Changeset in xpra [7980] by
- updated release notes
- 10:24 Changeset in xpra [7979] by
- r7924 for v0.14.x branch: try to prevent sound deadlocks on connection …
- 10:22 Changeset in xpra [7978] by
- r7970 + r7972 for v0.14.x branch: avoid errors when very limited …
- 10:19 Changeset in xpra [7977] by
- r7942 + most of r7964: fix compatibility with Fedora 21+ Xorg suid wrappers
- 10:17 Changeset in xpra [7976] by
- r7946 + new profile from r7937: add new GUIDs found in newer drivers …
- 10:09 Changeset in xpra [7975] by
- r7549 for v0.14.x branch: fix pillow deprecation warning
- 10:01 Changeset in xpra [7974] by
- #717: disable zero copy opengl upload to prevent crashes
- 10:00 Changeset in xpra [7973] by
- version bump
10/24/14:
- 20:58 Changeset in xpra [7972] by
- always use the video source so that we can still support client that …
- 20:52 Changeset in xpra [7971] by
- provide a more meaningful error message when no matching encoding are found
- 20:42 Changeset in xpra [7970] by
- avoid error and take shortcut if there are no fallback non video …
- 20:37 Changeset in xpra [7969] by
- fix logging error due to missing arg
- 20:31 Changeset in xpra [7968] by
- also skip (0,0) values - surely the last one?
- 20:30 Changeset in xpra [7967] by
- also skip False values
- 20:26 Changeset in xpra [7966] by
- ignore binary cuda files generated during build
- 19:57 Changeset in xpra [7965] by
- fix unit tests: make this class support non-str as keys again, don't …
- 19:46 Changeset in xpra [7964] by
- Fedora always needs the Xdummy wrapper (for various reasons), also add …
- 19:36 Changeset in xpra [7963] by
- add XIconifyWindow support
- 19:35 Changeset in xpra [7962] by
- make it easier to debug: only log non-None attributes
- 15:40 Changeset in xpra [7961] by
- if an application takes time to handle resize events, we can end up …
- 15:10 Changeset in xpra [7960] by
- don't rebuild cuda bits everytime, only when really needed: generalize …
- 14:16 Changeset in xpra [7959] by
- add hooks so we can debug X11 window creation events (only shown at …
- 13:44 Changeset in xpra [7958] by
- pre-compile the cuda kernels at build time and ship the fat binaries …
- 12:41 Changeset in xpra [7957] by
- we need cuda bits for nvenc3 OR nvenc4
10/23/14:
- 19:55 Ticket #721 (openh264 decoder) created by
- See https://github.com/cisco/openh264 as an alternative to the …
- 18:36 Ticket #720 (Path adjustments needed when installed with --user) created by
- When installed from source with setup.py install --user, the generated …
- 17:08 Ticket #719 (Hardcoded umasks limit some use cases) created by
- There are several places where xpra hardcodes umasks rather than …
10/21/14:
- 15:30 Ticket #718 (focus change requests in java applications does not work) created by
- As per the (ugly) example application attached to this ticket, it is …
10/19/14:
- 14:19 Changeset in xpra [7956] by
- new upstream release
10/17/14:
- 20:33 Ticket #717 (client crashes with opengl enabled and transparency) created by
- When attaching with this command line, in version 0.15.0: {{{xpra …
- 17:28 Changeset in xpra [7955] by
- run parallel encode test at 720p, maximum speed and lowest quality
- 17:01 Changeset in xpra [7954] by
- test a more "standard" resolution: use 720p
- 16:44 Changeset in xpra [7953] by
- default to testing 40 frames and 10 contexts per device, remove …
- 16:11 Changeset in xpra [7952] by
- logging cleanups and tweaks
- 16:04 Changeset in xpra [7951] by
- add new preset GUID to avoid warnings about unknown presets..
- 15:56 Changeset in xpra [7950] by
- but of course: copy and paste the NVENC code at your own peril, and …
- 15:35 Changeset in xpra [7949] by
- minor logging tweaks
- 15:35 Changeset in xpra [7948] by
- add test category to avoid warnings when running tests
- 15:35 Changeset in xpra [7947] by
- fix device info cache: ensure it does get populated, use the global …
- 15:34 Changeset in xpra [7946] by
- add new preset GUIDs to avoid warnings about unknown presets
- 14:52 Changeset in xpra [7945] by
- * update nvenc test for new full encoder api * re-instate commented …
- 13:09 Changeset in xpra [7944] by
- #653: NVENC SDKv4 support using a new 'nvenc4' encoder module: * …
- 12:46 Changeset in xpra [7943] by
- remove another remnant of the old avcodec module
- 10:49 Changeset in xpra [7942] by
- add workaround for Fedora 21+
- 03:54 Changeset in xpra [7941] by
- prettify output
- 03:33 Ticket #716 (rpm packages for supporting mp3 sound forwarding with centos / fedora) created by
- tasks: * new spec files * buildbot updates * testing
- 03:32 Changeset in xpra [7940] by
- packages needed for supporting mp3 sound without any external repositories
- 00:06 Ticket #715 (Cursor in YouTube search bar causes elevated bandwidth usage) created by
- Using nethogs to monitor bandwidth usage, and using epiphany to …
10/16/14:
- 02:18 Ticket #714 (ImportError: No module named gi.repository) closed by
-
invalid: If your
DISPLAY
is not set properly, you will not be able to …
10/15/14:
- 16:36 Changeset in xpra [7939] by
- #689: we need to do the websockify bit /after/ we instantiate the …
- 04:03 Changeset in xpra [7938] by
- oops: fix cut&paste gone wrong: convert --no-bell to --bell=no
10/14/14:
- 19:11 Ticket #714 (ImportError: No module named gi.repository) created by
- Hello, 1,8ghz I can run server, but no way to attach child session, …
- 05:32 Changeset in xpra [7937] by
- * move cuda bits to cuda_common * add version field now required with …
10/13/14:
- 21:17 Ticket #689 (make it easier to setup the html5 server) reopened by
- I am unable to get the html5 client to work or I am not understanding …
- 11:05 Ticket #713 (current using window is on top) created by
- After use xpra about 30 minutes -> 1 hour. Bellow bug appear: …
- 11:03 Changeset in xpra [7936] by
- add more sdk4 constants
- 10:13 Changeset in xpra [7935] by
- add high-444 preset guid
- 08:24 Ticket #712 (server is not responding) created by
- Server OS : Ubuntu 12.04 Client OS : Windows 7 I tried display info …
- 05:52 Changeset in xpra [7934] by
- log api version early so we can still see it in case of failures
- 04:29 Changeset in xpra [7933] by
- make it easier to choose which cuda sdk to build against, ie: …
- 04:14 Changeset in xpra [7932] by
- make it easier to build against nvenc SDK v4
10/11/14:
- 15:50 Source edited by
- (diff)
- 15:50 Source edited by
- (diff)
- 06:40 Changeset in xpra [7931] by
- Update to pygi-aio 3.14
- 06:39 Changeset in xpra [7930] by
- #640: ensure the label is a string (without the ugly quotes and 'b' prefix)
- 06:38 Changeset in xpra [7929] by
- whatever the input, we expect the output to be bytes or str, make it so
10/10/14:
- 08:47 Ticket #711 (extremely slow server - takes seconds to process events) closed by
- fixed: Fixed in r7928!
- 08:47 Changeset in xpra [7928] by
- #711: initialize websockify server later, so we can call the …
- 08:33 Changeset in xpra [7927] by
- add debug friendly repr for worker class
- 06:22 Ticket #711 (extremely slow server - takes seconds to process events) created by
- Only seems to occur if: * using trunk (0.14.x not affected) * not …
- 06:18 Changeset in xpra [7926] by
- r7912 for v0.14.x branch: fix tcsh (and others) compatibility
- 06:02 Changeset in xpra [7925] by
- add debug friendly strings for all binding classes
- 05:56 Changeset in xpra [7924] by
- shortcut out when we are closing down, seems to prevent sound deadlocks
- 05:43 Changeset in xpra [7923] by
- make sound easier to debug: * add more helpful repr string showing the …
- 04:26 Ticket #710 (Debian packaging is broken in 0.15) closed by
- invalid: Sorry to have wasted your time, the problem was at my end as usual (in …
10/09/14:
- 14:54 Changeset in xpra [7922] by
- when the window is not mapped yet and the client sends us the first …
- 10:31 ShadowServer edited by
- (diff)
- 10:26 Ticket #710 (Debian packaging is broken in 0.15) created by
- Nothing has changed in the debian directory for quite some time and …
- 09:55 Changeset in xpra [7921] by
- remove debug
- 03:33 Ticket #709 (configuring --without-sound leaves instance attribute undefined) closed by
- fixed: It is totally the right fix and has been applied in r7920. Thanks!
- 03:32 Changeset in xpra [7920] by
- #709: add missing "sound_source" attribute for when build does not …
10/08/14:
- 19:39 Ticket #704 (xpra does not correctly parse IPv6 addresses) closed by
- fixed: Thanks, seems to be working fine with 0.14.9. Closing.
- 18:46 Ticket #709 (configuring --without-sound leaves instance attribute undefined) created by
- I build from svn trunk 7906, configured --without-sound, and in order …
- 17:19 Changeset in xpra [7919] by
- doh: re-fix nvenc build, we expect it to be a number now
- 17:16 Changeset in xpra [7918] by
- remove more qt remnants
- 17:14 Changeset in xpra [7917] by
- doh: fix nvenc3 pkgconfig compatibility
- 17:09 Changeset in xpra [7916] by
- * remove remnants of the qt4 port * don't try to build shadow servers …
- 16:36 Changeset in xpra [7915] by
- don't run the tests with centos6, whose python2.6 is too old
- 16:21 Changeset in xpra [7914] by
- don't quote values that don't needed, means we can have stronger …
- 16:01 Changeset in xpra [7913] by
- add some early release notes for making beta builds
- 14:49 Changeset in xpra [7912] by
- some shells (ie: tcsh) don't like seeing more than one pipe …
- 11:51 Ticket #666 (start-child drops command line arguments) reopened by
-
Apparently, this may cause problems with
tcsh
: … - 09:14 Changeset in xpra [7911] by
- bump build no for python24 fix
- 09:11 Changeset in xpra [7910] by
- fix python 2.4 exception syntax compatibility
- 06:40 Changeset in xpra [7909] by
- * more integer vs float division fixes for python3.. * add more …
- 03:42 Changeset in xpra [7908] by
- #90 argument must be an integer not float! (and python3 default …
- 03:39 Changeset in xpra [7907] by
- #90: apparently, we can get a pixel buffer as a string, and array …
- 02:56 Ticket #163 (pass client DPI preference to server (and use sane defaults of 96dpi)) closed by
- fixed: I think we can close this for now.
- 02:54 Ticket #683 (unbundle python rencode rpm) closed by
- fixed
10/07/14:
- 21:35 Ticket #708 (Cannot switch window focus using keyboard on OS X) created by
- Cmd-` (backtick) is the default OS X binding for "Move focus to next …
- 16:14 Changeset in xpra [7906] by
- all this commit / shortcommit / ahead business is probably oh so very …
- 15:09 Changeset in xpra [7905] by
- new upstream releases
- 15:04 Changeset in xpra [7904] by
- ffmpeg version bump
- 14:52 Changeset in xpra [7903] by
- updated release notes
- 14:50 Ticket #707 (Fallout from shellshock fix) closed by
- fixed: Backport to v0.14.x in r7902. Closing, feel free to re-open if I've …
- 14:48 Changeset in xpra [7902] by
- r7898 for v0.14.x branch: workaround new bash shellshock env filtering …
- 10:33 Changeset in xpra [7901] by
- don't error out if client provides invalid values, just log the …
- 10:32 Changeset in xpra [7900] by
- more import loop prevention: import as needed
- 10:31 Changeset in xpra [7899] by
- don't call platform gui init from gtk_util, which may be causing …
- 08:24 Changeset in xpra [7898] by
- #707 workaround new bash env filtering
- 03:49 Ticket #559 (handle anti-aliasing and subpixel rendering, honour client component order) closed by
- fixed: > NativeGUI_info.exe ... shows RGB (and correct DPI), though rotating …
- 03:40 Ticket #692 (allow better control over automatic scaling) closed by
- fixed
10/06/14:
- 20:50 Ticket #707 (Fallout from shellshock fix) created by
- We recently upgraded bash on our RHEL cluster following the shellshock …
- 15:22 Changeset in xpra [7897] by
- updated release notes with ipv6 fix
- 15:21 Changeset in xpra [7896] by
- r7874 for v0.14.x branch: fix IPv6 parsing
- 15:16 Changeset in xpra [7895] by
- stable version bump
- 15:12 Changeset in xpra [7894] by
- r7893 for v0.14.x branch: avoid disabling the clipboard too early, …
- 15:07 Changeset in xpra [7893] by
- #703: bump nesting limit
- 15:06 Changeset in xpra [7892] by
- r7883 + r7877 + r7889 for v0.14.x branch: fix x11 keymap layout detection
- 15:01 Changeset in xpra [7891] by
- r7873 for v0.14.x branch: don't call the same handlers twice\!
- 14:59 Changeset in xpra [7890] by
- r7872 for v0.14.x branch: fix error message format
- 11:18 Ticket #706 (Input cjk text on forwarded window) created by
- This is not perhaps less a bug report than a seek for help. It may be …
- 06:27 Changeset in xpra [7889] by
- #631: whatever xkbcomp does with this data... we need it
- 06:25 Changeset in xpra [7888] by
- more detailed keyboard setup logging
- 05:56 Changeset in xpra [7887] by
- allow ":" in sanitized strings
- 04:25 Changeset in xpra [7886] by
- #661: log changes to XKLAVIER_STATE in the keyboard log
- 03:52 Changeset in xpra [7885] by
- add ability to more easily debug window properties
- 03:49 Ticket #705 (Java applications running with JDK6 or older can produce windows 1 ...) created by
- Attached is a very simple test case. […] Click on the button and …
10/05/14:
- 15:36 Changeset in xpra [7884] by
- oops: don't call handlers twice (cut&paste gone wrong?)
- 07:39 Changeset in xpra [7883] by
- #661: don't forget the "options" in the xkbmap query string, and it is …
- 07:26 Changeset in xpra [7882] by
- add debug logging to get_keymap_spec_from_xkb
- 07:15 Changeset in xpra [7881] by
- ensure debug shows something more helpful for gtk.gdk.Display, …
- 07:01 Changeset in xpra [7880] by
- ensure debug shows something more helpful, removing object address …
- 06:05 Changeset in xpra [7879] by
- remove dependency on gtk for looking up X11 props: re-use the …
10/04/14:
- 16:58 Changeset in xpra [7878] by
- * add executable script to easily see the keyboard data * add debug …
- 16:56 Changeset in xpra [7877] by
- #661: include all layouts in the "layout" string, not just the first one
- 16:23 Changeset in xpra [7876] by
- remove unused import
- 16:22 Changeset in xpra [7875] by
- new resolution found in logs from #661
- 06:07 Changeset in xpra [7874] by
- #704 fix for parsing IPv6 addresses
10/03/14:
- 18:02 Ticket #704 (xpra does not correctly parse IPv6 addresses) created by
- Giving xpra any IPv6 address to connect to, it fails connecting due to …
- 17:57 Changeset in xpra [7873] by
- we need a fallback case here
- 17:50 Changeset in xpra [7872] by
- pass a single string argument to the error callback!
- 17:33 Changeset in xpra [7871] by
- fix legacy "--enable-pings" command argument renaming
- 17:20 Changeset in xpra [7870] by
- #263: * ensure max-size honours window hints * win32 api must take …
- 17:19 Changeset in xpra [7869] by
- allow syntax W,H as well as WxH for max size
- 09:17 Changeset in xpra [7868] by
- #692: fix scaling-control control interface
- 05:59 Changeset in xpra [7867] by
- #263 we already deal with max-size ourselves, so remove it from the …
- 02:02 Changeset in xpra [7866] by
- fix for nxcomp
10/02/14:
- 10:47 Changeset in xpra [7865] by
- dec_avcodec is no more!
- 10:46 Changeset in xpra [7864] by
- those patches are for debian only, and we have a copy in …
- 10:23 Changeset in xpra [7863] by
- prevent debuild from moaning
- 09:56 Changeset in xpra [7862] by
- ship an html version of the manual page on platforms without "man" …
- 08:41 Usage edited by
- (diff)
- 08:22 FAQ edited by
- (diff)
- 08:14 PacketEncoding edited by
- (diff)
- 08:11 Changeset in xpra [7861] by
- rencode builds for all deb versions, so add dep
- 07:10 Changeset in xpra [7860] by
- debian packaging for rencode, ignoring: * …
- 06:57 Changeset in xpra [7859] by
- forgot to bump version here..
- 04:33 Changeset in xpra [7858] by
- #263: fix bug reported in #163: apply_geometry_hints takes just one …
- 03:21 Changeset in xpra [7857] by
- escape special characters to stop groff from moaning
10/01/14:
- 21:59 Ticket #703 (Copying URL from web browser address bar on remote host fails) created by
- Copying and pasting generally works fine from and to web browsers on …
- 19:34 Ticket #702 (Connection gets lost after eclipse auto-completion window is activated) created by
- Hello, Every so often, my xpra client connection is lost. Sometimes …
- 17:52 Ticket #699 (Make Menu Selections Persistent) closed by
- fixed
- 15:37 Debugging edited by
- (diff)
- 11:02 Changeset in xpra [7856] by
- use convenience platform aliases
- 10:47 Changeset in xpra [7855] by
- blacklist MSVCR90.DLL, we shouldn't be shipping anything that links …
- 06:25 Changeset in xpra [7854] by
- #177 fix tests for running from the specfile: * tweak PYTHONPATH so it …
- 05:55 Changeset in xpra [7853] by
- remove unused nosound option
- 05:31 Changeset in xpra [7852] by
- add XPRA_DPI_AWARE env var to more easily toggle support for it …
- 04:27 Ticket #701 (xpra launcher causes new menus to show in global menu bar on osx) created by
- Launching from the command line works fine. We're probably …
- 03:47 Changeset in xpra [7851] by
- updated release notes
- 03:45 Changeset in xpra [7850] by
- r7416 for v0.14.x branch: workaround GTK reporting an invalid bit …
- 03:35 Changeset in xpra [7849] by
- #163 I think passing "-dpi 96" to Xorg is now redundant and unhelpful
- 01:57 Ticket #673 (Change sound server option) closed by
- worksforme: Not heard back. Closing. (default should be unchanged anyway)
- 01:46 Changeset in xpra [7848] by
- add nxcomp and nxproxy
- 01:38 Ticket #700 (CentOS 6.4 client is often rendering large portions of window in black) created by
- With CentOS 0.14.3 client, scrolling sometimes causes various portions …
09/30/14:
- 23:14 Ticket #699 (Make Menu Selections Persistent) created by
- When we select certain features we want from the Features and Encoding …
- 12:04 Changeset in xpra [7847] by
- add antialias info to xpra info
- 10:46 Changeset in xpra [7846] by
- #559: let win32 clients fall through to the contrast code
- 10:08 Changeset in xpra [7845] by
- #559 override the antialias xsettings with the values we get from the …
- 06:04 Changeset in xpra [7844] by
- since we have more dpi values than we expose through the narrower …
- 05:50 Changeset in xpra [7843] by
- #163: * platforms can now supply two DPI values: one for each axis * …
- 05:31 Changeset in xpra [7842] by
- I made a mess of the release numbers.. we should just keep the …
- 04:41 Changeset in xpra [7841] by
- #163: add X11 dpi detection to xposix platform, either using Xft.dpi …
- 02:58 Ticket #687 (python-lz4 BuildRequires python-setuptools) closed by
- fixed: Not heard back, closing.
- 02:57 Ticket #643 (client remains running on server upgrade (on shared SSH connection)) closed by
- needinfo: Not heard back, closing.
- 02:36 Ticket #689 (make it easier to setup the html5 server) closed by
- fixed: Closing.
09/29/14:
- 18:10 Changeset in xpra [7840] by
- might as well do things properly: provide a get_dpi() function (and …
- 17:50 Changeset in xpra [7839] by
- * ship our own gtkrc on win32 * use a more "native" win32 styling * …
- 15:57 Changeset in xpra [7838] by
- add missing logger from backport r7811
- 15:47 Changeset in xpra [7837] by
- updated release notes
- 15:42 Changeset in xpra [7836] by
- r7827 for v0.14.x branch: fix race with destroyed windows
- 15:28 Changeset in xpra [7835] by
- according to the spec, -1 means default, so we just don't specify it …
- 15:22 Changeset in xpra [7834] by
- * use new pure-X11 xsettings code so we can safely get the antialias …
- 14:46 Changeset in xpra [7833] by
- remove the need for GTK to access the X11 display via the bindings: …
- 13:57 Changeset in xpra [7832] by
- make it easier to see what we get from xsettings
- 13:52 Changeset in xpra [7831] by
- remove debug
- 10:46 Changeset in xpra [7830] by
- #559: * collect antialias info using win32 native SystemParametersInfo? …
- 09:50 Ticket #698 (gtk is confused about some win32 screen settings) created by
- It reports 42 bits per pixel on my screen. As can be seen here in the …
- 09:29 Enhancements edited by
- (diff)
- 09:25 Changeset in xpra [7829] by
- r7823 for v0.14.x branch: fix dpi issues with ms windows and high dpi …
- 09:09 Changeset in xpra [7828] by
- don't register the refresh callback if we don't need it
- 09:08 Changeset in xpra [7827] by
- fix bug reported in #695: draw_region runs in a non-UI thread, so it …
- 08:52 Changeset in xpra [7826] by
- add workarea detection which is missing from GTK: * move …
- 06:39 Changeset in xpra [7825] by
- expose client vrefresh rate to the server, also log the server's vfb …
- 06:07 Changeset in xpra [7824] by
- * add win32 double click distance detection via native code (not found …
- 04:32 Changeset in xpra [7823] by
- #697: we must call SetProcessDpiAware?() before loading GTK, because …
- 04:14 Changeset in xpra [7822] by
- only collect version info when requested, and cache the results
Note: See TracTimeline
for information about the timeline view.